Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest Rust nightly v1.75 #1065

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Upgrade to latest Rust nightly v1.75 #1065

merged 6 commits into from
Oct 30, 2023

Conversation

kevinaboos
Copy link
Member

@kevinaboos kevinaboos commented Oct 28, 2023 •
edited
Loading

tsoutsman
tsoutsman approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@tsoutsman tsoutsman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that the ovmf-prebuilt dependency was still in the lock file. Looks good other than clippy. Is there a reason we don't use THESEUS_MERGED_SEC_SHNDX any more?

@tsoutsman
Fix clippy warnings
2cda740 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Merge branch 'theseus_main' into update_rust_toolchain
9ea39cf 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Fix merged clippy warnings
254ba65 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@tsoutsman
Copy link
Member

From Discord:

One new issue that I observed is that there are now GROUP sections (classified as COMDAT groups) for the rust_eh_personality sections (which are related to unwinding), but they only show up in aarch64 builds AFAICT.
I'm not sure if this is something that we need to be aware of; in the past I did not pay any attention to personality sections because we don't use that in our unwinder.
In any case, I just added a quick workaround to allow crate loading to work by ignoring the section.

@tsoutsman
Fix bitflags clippy warnings
984e780 
Signed-off-by: Klimenty Tsoutsman <klim@tsoutsman.com>
@kevinaboos
Copy link
Member Author

Is there a reason we don't use THESEUS_MERGED_SEC_SHNDX any more?

the existence of a GROUP section type may come before it, so I took a less fragile approach of looking for the .theseus_merged section anywhere before the .text* sections, since that is definitely under the control of our linker script.

@kevinaboos kevinaboos merged commit 7ee342e into theseus_main Oct 30, 2023
4 checks passed
@kevinaboos kevinaboos deleted the update_rust_toolchain branch October 30, 2023 22:13
github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@kevinaboos
Upgrade to latest Rust nightly v1.75 (#1065)
4dc08ff 
Co-authored-by: Klimenty Tsoutsman <klim@tsoutsman.com> 7ee342e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsoutsman tsoutsman tsoutsman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinaboos @tsoutsman